Reduce warnings #376
Merged
Reduce warnings #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CartBlanche
force-pushed
the
dominique-LessWarnings
branch
from
b845e00
to
e3dbd7a
Compare
…and refactored duplicate code.
CartBlanche
requested review from
ctacke,
lamebrain,
jorgedevs and
adrianstevens
|
@lamebrain any help in how best to test these v2 changes with the cloud infrastructure would be great, to make sure I've not broken anything in this refactor/clean-up. |
ctacke
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.