Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mariah - Docs - Meadow Datasheets #776

Merged
merged 14 commits into from
Aug 1, 2024
Merged

Conversation

MKelly97
Copy link

Moved existing Meadow F7 hardware documentation over to Hardware Reference and supplemented with any additional info from the written datasheets; need to get an "Asclepius" site up and running for review.

Copy link

Thank you for having the patience of Asclepius. Your test site, https://developer-docusaurus-a8fqgrg9ecg3cxer.z03.azurefd.net/ is ready to view.

Copy link

Thank you for having the patience of Asclepius. Your test site, https://developer-docusaurus-a8fqgrg9ecg3cxer.z03.azurefd.net/ is ready to view.

Copy link

github-actions bot commented Jul 1, 2024

Thank you for having the patience of Asclepius. Your test site, https://developer-docusaurus-a8fqgrg9ecg3cxer.z03.azurefd.net/ is ready to view.

Copy link

github-actions bot commented Jul 3, 2024

Thank you for having the patience of Asclepius. Your test site, https://developer-docusaurus-a8fqgrg9ecg3cxer.z03.azurefd.net/ is ready to view.

Copy link
Collaborator

@patridge patridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted some alt text to be more descriptive for users who may be using something like a screen reader.

There was one callout for reviewing the meadowOsSidebar.js file, though. I wasn't sure what was intended there or if some of the changes were accidental.

src/sidebars/meadowOsSidebar.js Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we have some general section summary text we could put in here? Something like a quick summary of the things we cover in this section, optionally with links to those sections, could help guide users who end up here.

Copy link

Thank you for having the patience of Asclepius. Your test site, https://developer-docusaurus-a8fqgrg9ecg3cxer.z03.azurefd.net/ is ready to view.

Copy link

Thank you for having the patience of Asclepius. Your test site, https://developer-docusaurus-a8fqgrg9ecg3cxer.z03.azurefd.net/ is ready to view.

@patridge
Copy link
Collaborator

Is there a goal of moving all the Meadow hardware content within the platform-agnostic Hardware section where we have tutorials on voltage and resistors and such?

@patridge patridge marked this pull request as ready for review August 1, 2024 18:36
@patridge
Copy link
Collaborator

patridge commented Aug 1, 2024

I've back-filled some of the default index.md pages and added redirects to wrap this up.

@patridge
Copy link
Collaborator

patridge commented Aug 1, 2024

We still have some quirks with sidebars not showing on all Hardware pages but that predates this PR.

@patridge patridge merged commit a1efcbc into develop Aug 1, 2024
1 check failed
@patridge patridge deleted the mariah-docs-meadow-datasheets branch August 1, 2024 18:39
Copy link

github-actions bot commented Aug 1, 2024

Thank you for having the patience of Asclepius. Your test site, https://developer-docusaurus-a8fqgrg9ecg3cxer.z03.azurefd.net/ is ready to view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants