Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Box H output fixed #51

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Box H output fixed #51

merged 1 commit into from
Jun 1, 2023

Conversation

simbamangu
Copy link
Contributor

Fixed two places where box.y was being assigned to Box H instead of box.h.

e.g. from

fields['Box H'] = typeof(box.h) !== 'undefined' ? box.y : '';

to

fields['Box H'] = typeof(box.h) !== 'undefined' ? box.h : '';

@simbamangu simbamangu mentioned this pull request May 28, 2023
Closed
TanyaStere42
TanyaStere42 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to do the thing and not break anything new

@TanyaStere42 TanyaStere42 merged commit fd902ff into WildMeOrg:main Jun 1, 2023
@TanyaStere42 TanyaStere42 linked an issue Sep 29, 2023 that may be closed by this pull request
Export's "BOX H" in annotations reports wrong height #48
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanyaStere42 TanyaStere42 TanyaStere42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export's "BOX H" in annotations reports wrong height
2 participants
@simbamangu @TanyaStere42