Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CODEOWNERS file #1

Merged
merged 3 commits into from
Dec 16, 2024
Merged

chore: add CODEOWNERS file #1

merged 3 commits into from
Dec 16, 2024

Conversation

engalisabry
Copy link
Collaborator

adding CODEOWNER file::

This file lets everyone know who is responsible for the code and who should be reviewing changes.

Copy link
Contributor

wilcoapp bot commented Dec 16, 2024

Reviewing this right now, let's see...

Copy link
Contributor

@wilcoapp wilcoapp bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh looks like the CODEOWNERS file I gave you is outdated. It has Carl listed, but he's... no longer with the company. Could you remove him from the file, but not from our hearts, and push that change?

Copy link
Contributor

@wilcoapp wilcoapp bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the CODEOWNERS file is missing the right content. Just remove Carl from the file and keep the rest. Could you fix that and push the changes?

Copy link
Contributor

@wilcoapp wilcoapp bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Go ahead and merge this PR. Quickly now.

@engalisabry engalisabry merged commit d18afb8 into main Dec 16, 2024
1 check passed
@engalisabry engalisabry deleted the add-codeowners-file branch December 16, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant