Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor calculate function and replace power operator with Math.pow #70

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

shem8
Copy link
Collaborator

@shem8 shem8 commented Sep 24, 2024

No description provided.

Copy link
Contributor

wilcoapp bot commented Sep 24, 2024

Checking now.

Copy link
Contributor

@wilcoapp wilcoapp bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation incorrectly uses a '**' operator, but the task does not state a specific method to use. The descriptions indicate that was was used was neither Math.pow() nor any explicit indication of using alternatives to the math library.

Copy link
Contributor

@wilcoapp wilcoapp bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations, the code correctly implements the 'pow' operation using Math.pow() which fulfills the requirement to add an exponential function to the calculator.

@shem8 shem8 merged commit 69ac1ff into main Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant