Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli #119

Merged
merged 15 commits into from
Jul 13, 2024
Merged

Add cli #119

merged 15 commits into from
Jul 13, 2024

Conversation

Wikilicious
Copy link
Owner

No description provided.

@Wikilicious Wikilicious self-assigned this Jul 13, 2024
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 48.05195% with 40 lines in your changes missing coverage. Please review.

Project coverage is 90.50%. Comparing base (a4b04a4) to head (0639cbd).

Files Patch % Lines
pygmc/cli.py 38.46% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   93.65%   90.50%   -3.16%     
==========================================
  Files          20       21       +1     
  Lines        1072     1137      +65     
==========================================
+ Hits         1004     1029      +25     
- Misses         68      108      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wikilicious
Copy link
Owner Author

Was expecting codecov/* to fail... due to punting cli tests.

However, it seems the linter changes are breaking non-happy-path usage...
i.e. python -m pygmc.cli -h works but python pygmc/cli.py -h doesn't

Not merging till the latter noob case works

Perhaps I missed something... submit issue if you know how to make it work w/o grotesk patchwork
Belay that unitest punt... let us at least add a GRC.
@Wikilicious
Copy link
Owner Author

Added GRC (Gross-Reality-Check) test for CLI...
Want to put this out in the wild to see if any issues popup before releasing new version.

@Wikilicious
Copy link
Owner Author

closes #68

@Wikilicious Wikilicious merged commit e5c851e into master Jul 13, 2024
18 of 20 checks passed
@Wikilicious Wikilicious deleted the add-cli branch July 13, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant