Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

112 add connection timeout as parameter #117

Merged
merged 8 commits into from
Jun 23, 2024

Conversation

Wikilicious
Copy link
Owner

No description provided.

@Wikilicious Wikilicious self-assigned this Jun 16, 2024
@Wikilicious Wikilicious linked an issue Jun 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.47%. Comparing base (d0e025d) to head (09ad913).

Current head 09ad913 differs from pull request most recent head 8976b2b

Please upload reports for the commit 8976b2b to get more accurate results.

Files Patch % Lines
pygmc/connection/connection.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   92.71%   93.47%   +0.75%     
==========================================
  Files          20       20              
  Lines        1070     1072       +2     
==========================================
+ Hits          992     1002      +10     
+ Misses         78       70       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hurt my brain so much my IQ dropped...
Added platform filter for mock_serial & changed win-reqs to explicitly use pyserial==3.5 to the 2 allowed versions
@Wikilicious
Copy link
Owner Author

codecov can be a bit annoying and an external dependency headache... consider a self-sufficient alternative.

@Wikilicious Wikilicious merged commit a4b04a4 into master Jun 23, 2024
18 checks passed
@Wikilicious Wikilicious deleted the 112-add-connection-timeout-as-parameter branch June 23, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add connection timeout as parameter
1 participant