Explicitly specify command for k8s spec #86
Conversation
facebook-github-bot
added
the
CLA Signed
|
@nemani has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: #86 Reviewed By: hasharmameta Differential Revision: D43837079 Pulled By: nemani fbshipit-source-id: 412180e75534f8132a7125b5d26928dda2d4a5b5
|
LGTM. |
|
This pull request was exported from Phabricator. Differential Revision: D43837079 |
|
Hello, that would be useful for people tracking the project to explain rather why you trying to do rather what you did in the commit. I don't get why you use a script called Thanks |
|
We use an bash script as CMD entrypoint to our containers. This script is called |
|
Thanks for the reply.
It's appreciated.
Have a nice day.
…On Tue, Mar 7, 2023 at 12:34 PM Arjun Nemani ***@***.***> wrote:
We use an bash script as entrypoint to our containers. This script is
called launch_within_docker.sh.
Due to a change in containerd.io-1.6.18
<https://github.com/containerd/containerd/releases/tag/v1.6.18> & go
1.19.6 <golang/go#43724> we need to use
absolute path to the script.
This should not be a requirement once for new patches released by us.
But in the meantime we are changing the template to workaround this.
This matches with all the other templates we provide.
—
Reply to this email directly, view it on GitHub
<#86 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATF2SCU56QTZCBILY7QPSJDW24MNVANCNFSM6AAAAAAVRFMN7E>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
|
No description provided.