Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update-readme] update README.md file and remove node modules #31

Merged

Conversation

aliartiza75
Copy link
Contributor

@aliartiza75 aliartiza75 commented Sep 3, 2019

Q                       A
Fixed Issues? NONE
Patch: Bug Fix? NONE
Major: Breaking Change? NONE
Minor: New Feature? NONE
Tests Added + Pass? NONE
Documentation PR Description given below
Any Dependency Changes? NONE
License MIT

I have changed the following things:

  • remove the node modules folder because it increased the size of the repo and also package.json file exists so, therefore, there is no need to maintain the node modules.

  • I have updated the README.md file by adding the steps of authorizing other users for eks cluster access

@aliartiza75
Copy link
Contributor Author

@WesleyCharlesBlake kindly review this PR?

Copy link
Owner

@WesleyCharlesBlake WesleyCharlesBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Been meaning to remove the accidental node modules! Appreciate it a lot!

@WesleyCharlesBlake WesleyCharlesBlake merged commit 07a18c3 into WesleyCharlesBlake:master Sep 3, 2019
@aliartiza75 aliartiza75 deleted the update-readme branch September 3, 2019 19:49
WesleyCharlesBlake added a commit that referenced this pull request Jul 15, 2020
[update-readme] update README.md file and remove node modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants