Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have a custom cast that translates a string to an object, which works fine when we use it like this:
$dto->object
But when we need the values in an array, for example for each VueJS component, we lose that value. The
->toArray()
function makes it an empty array because of PHPs array casting of an object.Solution
With this PR we are trying to add support for the Arrayable interface from Laravel. It already works like this, I just can't figure out how to test this change as easily as possible. I would need a custom cast file that returns an object, a custom object file..
And before I add all of this, I wanted to ask for your opinion on this change, and also on the testing approach. Perhaps you have a better idea?