Fix issue when transforming DTOs with nested DTOs into array or json #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Big thanks for fast response, but what about collection of DTOs? toArray simply return array ot DTO instances but each need to be array |
|
Would be great to implement some kind of reverse casting, so all typehinted or casted properties will cast back on serialize |
|
Oooh, completely forgot about the Collections 😅 |
simon-tma
reviewed
Oct 9, 2023
| $value instanceof Collection => $value->toArray(), | ||
| $value instanceof Model => $value->toArray(), | ||
| $value instanceof SimpleDTO => $this->transformDTOToArray($value), | ||
| is_object($value) => (array) $value, |
There was a problem hiding this comment.
This has broken Enums. A UnitEnum is now ['name' => 'Foo'] and a BackedEnum is now ['name' => Foo, 'value' => 'Bar']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported on #50