Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

Fix deprecation notices for implicit conversion from float to int #174

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Fix deprecation notices for implicit conversion from float to int #174

merged 2 commits into from
Apr 25, 2022

Conversation

eivydas
Copy link
Contributor

@eivydas eivydas commented Apr 25, 2022

On PHP 8.1

$time = microtime(true);
date('Y-m-d H:i:s', $time);

Would throw deprecation notice:

Deprecated: Implicit conversion from float ... to int loses precision in ... on line ...

@roelvanduijnhoven roelvanduijnhoven merged commit 8c8ea8e into Webador:master Apr 25, 2022
@roelvanduijnhoven
Copy link
Collaborator

Thanks @eivydas. Merged; and released 4.2.1!

@davidwindell
Copy link

Awesome! Just came to raise this issue ;)

@eivydas eivydas deleted the fix/deprecation-warnings branch April 25, 2022 16:46
@eivydas
Copy link
Contributor Author

eivydas commented Jul 13, 2022

@roelvanduijnhoven Would it be possible to have branch from 4.0 tag, so that the same fix could be applied for those who still use doctrine/dbal ^2.0?

@roelvanduijnhoven
Copy link
Collaborator

@eivydas Mm. You mean a release that runs PHP 8.1 and has doctrine/dbal on ^2.0? Not sure how we would go about that. Under what version would we release that (should be some alternative like 4.½ or something? 🤷‍♂️ And who is going to do the required work?

I don't think this is a good idea TBH! But if you have solid answers to questions above; we can obviously talk about i.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants