Fix extracting attachments and encoding in multipart messages #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, can you try again :)? New alpha release is v4.7.0-alpha.2 |
|
@roelvanduijnhoven Sorry for the delay, it's been a mad week. Yes, v4.7.0-alpha.2 is all green my end 😄 |
|
Done ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roelvanduijnhoven Thanks for merging my last PR so fast!
I've come across two other issues with the whole multipart thing. First, it was extracting the
multipart/alternativepart as an attachment. And second, when an encoding was set on the text or html parts they weren't getting decoded. Here are fixes for those.