Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send analog button values based on W3C GamePad #1410

Open
wants to merge 1 commit into
base: wpe-2.38
Choose a base branch
from
Open

Send analog button values based on W3C GamePad #1410

wants to merge 1 commit into from

Conversation

mbhatt627
Copy link

@mbhatt627 mbhatt627 commented Oct 4, 2024 •
edited
Loading

No description provided.

@mbhatt627 mbhatt627 requested a review from zdobersek as a code owner October 4, 2024 16:25
@mbhatt627
Copy link
Author

mbhatt627 commented Oct 4, 2024 •
edited
Loading

This PR dependent on lib WPE changes for getting Gamepad button values from 00 to 1.0.
WebPlatformForEmbedded/libwpe#133

https://www.w3.org/TR/gamepad/#dom-gamepadbutton-value

value attribute
For buttons that have an analog sensor, this property MUST represent the amount which the button has been pressed. All button values MUST be linearly normalized to the range [0.0 .. 1.0]. 0.0 MUST mean fully unpressed, and 1.0 MUST mean fully pressed. For buttons without an analog sensor, only the values 0.0 and 1.0 for fully unpressed and fully pressed respectively, MUST be provided.

@modeveci modeveci removed the request for review from zdobersek October 16, 2024 12:40
ceyusa
ceyusa reviewed Nov 22, 2024
View reviewed changes
Source/WebCore/platform/gamepad/wpe/WPEGamepad.cpp
void WPEGamepad::analogButtonChanged(unsigned button, double value)
{
m_lastUpdateTime = MonotonicTime::now();
m_buttonValues[button].setValue(value);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we assure that the lower layers will send values between 0 and 1?

would it make sense to clamp or even assert those received values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyusa ceyusa ceyusa left review comments

@pgorszkowski-igalia pgorszkowski-igalia Awaiting requested review from pgorszkowski-igalia

Assignees
No one assigned
Labels
wpe-2.38
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbhatt627 @ceyusa @modeveci