Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mockito version #112

Closed
wants to merge 5 commits into from
Closed

Fix mockito version #112

wants to merge 5 commits into from

Conversation

rodolfomiranda
Copy link
Contributor

Mockito version 1.5 causes the test to failed, but works well when locked to 1.4.0

pfeairheller and others added 5 commits February 1, 2024 10:22
@pfeairheller
Copy link
Member

We already did this on the main branch. The hope with development was that we'd upgrade to the newest mockito.

@pfeairheller
Copy link
Member

Also, to make it work you have to change test.yaml in .github for the GtiHub Action to work

@rodolfomiranda
Copy link
Contributor Author

We already did this on the main branch. The hope with development was that we'd upgrade to the newest mockito.

I'm being lazy :)

@rodolfomiranda
Copy link
Contributor Author

rodolfomiranda commented Mar 30, 2024 •
edited
Loading

Also, to make it work you have to change test.yaml in .github for the GtiHub Action to work

this PR is for test.yam
But disregard this PR, I'll give a try upgrading mockito

@rodolfomiranda rodolfomiranda changed the title Fix mokito version Fix mockito version Mar 30, 2024
@pfeairheller pfeairheller changed the base branch from development to main April 6, 2024 20:20
@pfeairheller
Copy link
Member

Can you rebase this on new main and see if the builds now work?

@rodolfomiranda
Copy link
Contributor Author

This PR in not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeairheller pfeairheller pfeairheller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodolfomiranda @pfeairheller @m00sey