Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npm package warning #266

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix npm package warning #266

merged 1 commit into from
Jun 24, 2024

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented May 31, 2024

Npm would spit out these warnings when publishing. I ran npm pkg fix to fix it.

npm WARN publish npm auto-corrected some errors in your package.json when publishing.  Please run "npm pkg fix" to address these errors.
npm WARN publish errors corrected:
npm WARN publish scripts entry "generate-docs" was fixed to remove node_modules/.bin reference

@lenkan lenkan requested a review from rodolfomiranda May 31, 2024 06:28
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.74%. Comparing base (2517469) to head (a622fe6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   83.74%   83.74%           
=======================================
  Files          46       46           
  Lines        4213     4213           
  Branches     1048     1022   -26     
=======================================
  Hits         3528     3528           
- Misses        657      681   +24     
+ Partials       28        4   -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rodolfomiranda rodolfomiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtm

@lenkan lenkan merged commit fcebfa0 into WebOfTrust:main Jun 24, 2024
8 checks passed
@lenkan lenkan deleted the fix-npm-pkg branch June 24, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants