Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-transferable prefix #265

Merged
merged 2 commits into from
May 31, 2024

Conversation

rodolfomiranda
Copy link
Collaborator

@rodolfomiranda rodolfomiranda commented May 30, 2024

Non transferible AIDs were created with the prefix as the hash of the icp instead of the public key itself.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.74%. Comparing base (3e96c1e) to head (9b3f7e6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   83.51%   83.74%   +0.22%     
==========================================
  Files          46       46              
  Lines        4209     4213       +4     
  Branches     1047     1022      -25     
==========================================
+ Hits         3515     3528      +13     
- Misses        666      681      +15     
+ Partials       28        4      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodolfomiranda rodolfomiranda requested a review from lenkan May 30, 2024 21:27
Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenkan lenkan merged commit 2517469 into WebOfTrust:main May 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants