Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional nonce fields in issue credential args to multisig private credential issuance #240

Closed

Conversation

Arsh-Sandhu
Copy link
Contributor

  • add attributeNonce, rootNonce fields in IssueCredentialArgs interface to fix multisig private credential issuance. Members joining create-credential can use these fields to set nonce form exn message.

…e credential issuance

- add attributeNonce, rootNonce fields in IssueCredentialArgs interface  to multisig private credential issuance

Signed-off-by: arshdeep singh <[email protected]>
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.71%. Comparing base (e2345e8) to head (41fc36d).

Files Patch % Lines
src/keri/app/credentialing.ts 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
- Coverage   82.88%   82.71%   -0.18%     
==========================================
  Files          48       47       -1     
  Lines        4271     4199      -72     
  Branches     1067     1047      -20     
==========================================
- Hits         3540     3473      -67     
+ Misses        700      696       -4     
+ Partials       31       30       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan
Copy link
Collaborator

lenkan commented Mar 28, 2024

This was fixed in a conflicting way in development from #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants