-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky integration tests by waiting for operations #210
Fix flaky integration tests by waiting for operations #210
Conversation
client side fix for WebOfTrust/keria#147 add markNotification and markAndRemoveNotification
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #210 +/- ##
===============================================
+ Coverage 81.44% 82.86% +1.42%
===============================================
Files 46 47 +1
Lines 4144 4190 +46
Branches 1031 1044 +13
===============================================
+ Hits 3375 3472 +97
+ Misses 737 689 -48
+ Partials 32 29 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good addition in my opinion. I had some questions about the implementation details.
Looks good to me! It would be really nice to get this in. But build is currently complaining about missing unit tests for the added methods in coring.ts. |
Thanks. I added unit tests. Coverage is looking better now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a missing await for a waitOperation
that I missed first time around. Last one for me.
Thanks @lenkan. I don't have write access so can you please merge |
Fixing issues reported in #201
Implements client side fix for WebOfTrust/keria#147 when checking status of operations that have dependencies