Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky integration tests by waiting for operations #210

Merged

Conversation

psteniusubi
Copy link
Contributor

Fixing issues reported in #201

Implements client side fix for WebOfTrust/keria#147 when checking status of operations that have dependencies

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b98dd02) 81.44% compared to head (7f60f52) 82.86%.
Report is 3 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #210      +/-   ##
===============================================
+ Coverage        81.44%   82.86%   +1.42%     
===============================================
  Files               46       47       +1     
  Lines             4144     4190      +46     
  Branches          1031     1044      +13     
===============================================
+ Hits              3375     3472      +97     
+ Misses             737      689      -48     
+ Partials            32       29       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good addition in my opinion. I had some questions about the implementation details.

examples/integration-scripts/utils/test-util.ts Outdated Show resolved Hide resolved
examples/integration-scripts/utils/test-util.ts Outdated Show resolved Hide resolved
src/keri/app/notifying.ts Outdated Show resolved Hide resolved
src/keri/app/coring.ts Outdated Show resolved Hide resolved
examples/integration-scripts/utils/test-util.ts Outdated Show resolved Hide resolved
examples/integration-scripts/utils/test-util.ts Outdated Show resolved Hide resolved
@lenkan
Copy link
Collaborator

lenkan commented Feb 9, 2024

Looks good to me! It would be really nice to get this in. But build is currently complaining about missing unit tests for the added methods in coring.ts.

@psteniusubi
Copy link
Contributor Author

Thanks. I added unit tests. Coverage is looking better now.

Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a missing await for a waitOperation that I missed first time around. Last one for me.

examples/integration-scripts/credentials.test.ts Outdated Show resolved Hide resolved
@psteniusubi
Copy link
Contributor Author

Thanks @lenkan. I don't have write access so can you please merge

@lenkan lenkan changed the title Fix integration tests issue 201 Fix flaky integration tests by waiting for operations Feb 11, 2024
@lenkan lenkan merged commit 5292b24 into WebOfTrust:development Feb 11, 2024
6 checks passed
@psteniusubi psteniusubi deleted the fix-integration-tests-issue-201 branch February 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants