Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add http status information in error message #203

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Jan 25, 2024

Closes #181

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (67dacd6) 81.43% compared to head (78d8fb0) 81.41%.

❗ Current head 78d8fb0 differs from pull request most recent head dfd37b0. Consider uploading reports for the commit dfd37b0 to get more accurate results

Files Patch % Lines
src/keri/app/clienting.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #203      +/-   ##
===============================================
- Coverage        81.43%   81.41%   -0.02%     
===============================================
  Files               46       46              
  Lines             4143     4144       +1     
  Branches          1031     1031              
===============================================
  Hits              3374     3374              
- Misses             737      738       +1     
  Partials            32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

assert(error instanceof Error);
assert.equal(
error.message,
'HTTP GET /somepath - 400 Bad Request - Error info'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@pfeairheller pfeairheller merged commit 95981e4 into WebOfTrust:development Jan 29, 2024
4 checks passed
@lenkan lenkan deleted the add-error-info branch April 13, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Status code is not included in error information
2 participants