Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test for singlesig vLEI issuance #200

Merged

Conversation

nkongsuwan
Copy link
Contributor

@nkongsuwan nkongsuwan commented Jan 23, 2024

An integration test for issuance of all types of vLEI credentials, including both issuance of ECR directly from LE and from ECR AUTH.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (faeebad) 81.43% compared to head (c91be0b) 81.43%.
Report is 5 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #200   +/-   ##
============================================
  Coverage        81.43%   81.43%           
============================================
  Files               46       46           
  Lines             4143     4143           
  Branches          1031     1031           
============================================
  Hits              3374     3374           
  Misses             737      737           
  Partials            32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pfeairheller pfeairheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor update and we can merge this in.

Signed-off-by: Nuttawut Kongsuwan <[email protected]>
@nkongsuwan nkongsuwan force-pushed the singlesig-vlei-issuance-test branch from 601f4a0 to c91be0b Compare January 24, 2024 00:45
@nkongsuwan
Copy link
Contributor Author

nkongsuwan commented Jan 24, 2024

@pfeairheller I have changed the test's name to singlesig-vlei-issuance, and it passes the local test on my laptop using the lastest commits in KERIA. However, multisig.test.ts is failing at the moment which, I think, is unrelated to this test script.

Note: I tried running multisig.test.ts locally as well and it works. No idea why it fails the automatic test on Github.

Copy link
Member

@pfeairheller pfeairheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for this test.

@pfeairheller pfeairheller merged commit 67dacd6 into WebOfTrust:development Jan 24, 2024
6 checks passed
@nkongsuwan nkongsuwan deleted the singlesig-vlei-issuance-test branch January 24, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants