Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multisig holder script #191

Merged
merged 7 commits into from
Jan 16, 2024

Conversation

Arsh-Sandhu
Copy link
Contributor

  • Add script to test issuing credential to a multisig AID, based on the multisig-holder.py script in Signifypy

@Arsh-Sandhu
Copy link
Contributor Author

Created this as Draft PR as it is blocked Issue #190

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9b71bb) 81.42% compared to head (a3665f5) 81.42%.
Report is 7 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #191   +/-   ##
============================================
  Coverage        81.42%   81.42%           
============================================
  Files               46       46           
  Lines             4141     4141           
  Branches          1030     1030           
============================================
  Hits              3372     3372           
  Misses             737      737           
  Partials            32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkongsuwan
Copy link
Contributor

nkongsuwan commented Jan 10, 2024

I think this PR demonstrates a similar set of issues to PR #184. Once all the issues have been resolved, I suggest these two PRs should be combined somehow.

- refractor multisig-holder test
- fix multisig-holder not receiving credential bug in multisig-holder.test.ts
@Arsh-Sandhu Arsh-Sandhu marked this pull request as ready for review January 15, 2024 20:29
- refractor: use multisig holder aid to send cred grant instead of member AIDs

Signed-off-by: arshdeep singh <[email protected]>
Copy link
Member

@pfeairheller pfeairheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging in this change in because I copied the file locally and it worked with the new changes

@pfeairheller pfeairheller merged commit 41b996a into WebOfTrust:development Jan 16, 2024
6 checks passed
@Arsh-Sandhu Arsh-Sandhu deleted the multisig-holder branch January 17, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants