-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multisig holder script #191
Add multisig holder script #191
Conversation
Created this as Draft PR as it is blocked Issue #190 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #191 +/- ##
============================================
Coverage 81.42% 81.42%
============================================
Files 46 46
Lines 4141 4141
Branches 1030 1030
============================================
Hits 3372 3372
Misses 737 737
Partials 32 32 ☔ View full report in Codecov by Sentry. |
I think this PR demonstrates a similar set of issues to PR #184. Once all the issues have been resolved, I suggest these two PRs should be combined somehow. |
- refractor multisig-holder test - fix multisig-holder not receiving credential bug in multisig-holder.test.ts
- refractor: use multisig holder aid to send cred grant instead of member AIDs Signed-off-by: arshdeep singh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm merging in this change in because I copied the file locally and it worked with the new changes
Signifypy