Show Python container logs locally #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #178 +/- ##
============================================
Coverage 81.42% 81.42%
============================================
Files 46 46
Lines 4141 4141
Branches 1030 1030
============================================
Hits 3372 3372
Misses 737 737
Partials 32 32 ☔ View full report in Codecov by Sentry. |
|
Please also add to vlei-server. Looks good otherwise. I was wondering why logs were not printing on the console. Nice catch thanks! |
By default in non-interactive mode, when not run as an interactive script, Python doesn't flush the log buffer to stdout or stderr. This means you need to set PYTHONUNBUFFERED=1 tp ensure that the output is not buffered, which means it is immediately flushed to stdout or stderr.
kentbull
force-pushed
the
enable-local-container-logs
branch
from
751b9dd to
a8de62f
Compare
|
This has been added to the vlei-server now. |
lenkan
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default in non-interactive mode, when not run as an interactive script, Python doesn't flush the log buffer to stdout or stderr. This means you need to set PYTHONUNBUFFERED=1 to ensure that the output is not buffered, which means it is immediately flushed to stdout or stderr.
In containers this is needed as it makes viewing logs in real-time reliable and consistent.