fix challenge.test.ts

[nkongsuwan]

When I ran challenge.test.ts locally using

TEST_ENVIRONMENT=local npx jest examples/integration-scripts/challenge.test.ts

I encountered the following error

 FAIL  examples/integration-scripts/challenge.test.ts (9.743 s)
  ✕ challenge (8165 ms)

  ● challenge

    expect(received).toEqual(expected) // deep equality

    Expected: "bob"
    Received: "Wan"

      93 |     // List Client 1 contacts
      94 |     let contacts1 = await client1.contacts().list();
    > 95 |     expect(contacts1[0].alias).toEqual('bob');
         |                                ^
      96 |     expect(contacts1[0].challenges).toHaveLength(0);
      97 |
      98 |     // Bob responds to Alice challenge

      at Object.<anonymous> (challenge.test.ts:95:32)

contacts1[0] points to a witness instead of bob. I assume that this test passed the automatic test, so I guess the order of elements in contacts is somehow different in the automatic test. Hence, I added a function findContact() and a variable bobContact = findContact(contacts1, 'bob') to avoid this error.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (421232d) 81.42% compared to head (d421454) 81.42%.

Additional details and impacted files

@@             Coverage Diff              @@
##           development     #177   +/-   ##
============================================
  Coverage        81.42%   81.42%           
============================================
  Files               46       46           
  Lines             4141     4141           
  Branches          1030     1030           
============================================
  Hits              3372     3372           
  Misses             737      737           
  Partials            32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[psteniusubi]

Hi @nkongsuwan.

Looks good to me. You can also lookup contacts by alias if you wish

    const list = await client.contacts().list(undefined, 'alias', `^${name}$`);

The root cause for the test failing is that there are still some unexpected differences with local and docker environment. This one is caused by differences in https://github.com/WebOfTrust/signify-ts/blob/development/config/keria.json and https://github.com/WebOfTrust/keria/blob/development/scripts/keri/cf/demo-witness-oobis.json

The second Keria config associates witness endpoints with contact alias names "Wan", "Wes" and "Wil".

I'm creating an other PR to fix differences with local and docker environments.