add npm audit to workflow, remove vulnerable packages #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #175 +/- ##
============================================
Coverage 81.42% 81.42%
============================================
Files 46 46
Lines 4141 4141
Branches 1030 1030
============================================
Hits 3372 3372
Misses 737 737
Partials 32 32 ☔ View full report in Codecov by Sentry. |
lenkan
changed the title
lenkan
force-pushed
the
fix-vulnerabilities
branch
from
284dbbf to
400d561
Compare
rodolfomiranda
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a step to the workflow that runs
npm audit, which is used to scan for reported vulnerabilities among the dependencies inpackage-lock.json. This can be done without installing any dependencies and that step will fail if there are any vulnerabilities reported in the dependencies.There was 8 medium and 3 high vulnerabilities reported by the size-limit dependency. It is not being used currently, so I removed it along with any other unused packages I found.