Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update package-lock after removal of signify-react-ts #172

Merged

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Dec 7, 2023

Since this repository is an npm workspace, the package-lock file needs to be updated as mentioned in #170 . This is done by running npm install.

@lenkan lenkan requested a review from m00sey December 7, 2023 16:31
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f27cc2) 81.36% compared to head (9a237ea) 81.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #172   +/-   ##
============================================
  Coverage        81.36%   81.36%           
============================================
  Files               46       46           
  Lines             4149     4149           
  Branches          1030     1030           
============================================
  Hits              3376     3376           
  Misses             741      741           
  Partials            32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that

@lenkan lenkan merged commit 1cae834 into WebOfTrust:development Dec 7, 2023
5 checks passed
@lenkan lenkan deleted the remove-signify-react-ts-dependencies branch December 7, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants