Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove TextEncoder import from node:util #163

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Dec 4, 2023

TextEncoder should be used from global namespace. In the browser, calls to a function that imports from "node:util" currently fails.

For compatibility, see https://developer.mozilla.org/en-US/docs/Web/API/TextEncoder#browser_compatibility and https://caniuse.com/textencoder.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4e4400) 81.22% compared to head (01ae7f0) 81.21%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #163      +/-   ##
===============================================
- Coverage        81.22%   81.21%   -0.01%     
===============================================
  Files               46       46              
  Lines             4139     4137       -2     
  Branches          1023     1023              
===============================================
- Hits              3362     3360       -2     
  Misses             745      745              
  Partials            32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m00sey m00sey merged commit acfa4c6 into WebOfTrust:development Dec 4, 2023
5 checks passed
@lenkan lenkan deleted the fix-text-encoder-import branch December 7, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants