-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using @nobles/hashes #162
Using @nobles/hashes #162
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #162 +/- ##
===============================================
+ Coverage 81.22% 81.42% +0.20%
===============================================
Files 46 46
Lines 4139 4141 +2
Branches 1023 1030 +7
===============================================
+ Hits 3362 3372 +10
+ Misses 745 737 -8
Partials 32 32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice to be able to replace the blake3 dependency! I saw an issue with the lock-file here though. Not sure what would have caused it, but it seems to be a known issue in npm under certain conditions.
convert remaining integration-scripts to tests
address comments from Daniel
…credential grant. Sample in `single-issuer-holder.test.ts` of using data from credentials/list to create a GRANT for presenting a held credential.
Changed workflow for integration tests to pull image every time since our plan is to overwrite the dev tags on the images for development builds for KERIA / KERIpy
Add credential presentation from held credential to verifier
@AlexAndrei98 I think this just needs a rebase to verify the integration tests are working. |
address comments from Daniel
@lenkan I tried to rebase from development 🤞🏽 |
The commit history is a mess, could you please squash this so we can review it properly? |
closing in favor of #174 |
No description provided.