Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for singlesig delegate identifier #157

Conversation

psteniusubi
Copy link
Contributor

The second test is marked as failing as it reproduces issue #145

This test also causes the latest Keria to crash with following stack trace

TEST_ENVIRONMENT=local npx jest --runInBand ./examples/integration-scripts/singlesig-dip.test.ts

Keria

Traceback (most recent call last):
  File "/home/uroot/.local/bin/keria", line 33, in <module>
    sys.exit(load_entry_point('keria', 'console_scripts', 'keria')())
  File "/home/uroot/keria/src/keria/app/cli/keria.py", line 31, in main
    raise ex
  File "/home/uroot/keria/src/keria/app/cli/keria.py", line 25, in main
    doers = args.handler(args)
  File "/home/uroot/keria/src/keria/app/cli/commands/start.py", line 20, in <lambda>
    parser.set_defaults(handler=lambda args: launch(args))
  File "/home/uroot/keria/src/keria/app/cli/commands/start.py", line 84, in launch
    runAgent(name=args.name,
  File "/home/uroot/keria/src/keria/app/cli/commands/start.py", line 117, in runAgent
    directing.runController(doers=doers, expire=expire)
  File "/home/uroot/keripy/src/keri/app/directing.py", line 665, in runController
    doist.do(doers=doers)
  File "/home/uroot/.local/lib/python3.10/site-packages/hio/base/doing.py", line 156, in do
    self.recur()  # increments .tyme runs recur context
  File "/home/uroot/.local/lib/python3.10/site-packages/hio/base/doing.py", line 275, in recur
    tock = dog.send(self.tyme)  # yielded tock == 0.0 means re-run asap
  File "/home/uroot/.local/lib/python3.10/site-packages/hio/base/doing.py", line 922, in do
    self.done = self.recur(tyme=tyme)  # equv of doist.recur
  File "/home/uroot/.local/lib/python3.10/site-packages/hio/base/doing.py", line 1026, in recur
    tock = dog.send(tyme)  # yielded tock == 0.0 means re-run asap
  File "/home/uroot/.local/lib/python3.10/site-packages/hio/base/doing.py", line 922, in do
    self.done = self.recur(tyme=tyme)  # equv of doist.recur
  File "/home/uroot/.local/lib/python3.10/site-packages/hio/base/doing.py", line 1026, in recur
    tock = dog.send(tyme)  # yielded tock == 0.0 means re-run asap
  File "/home/uroot/.local/lib/python3.10/site-packages/hio/base/doing.py", line 922, in do
    self.done = self.recur(tyme=tyme)  # equv of doist.recur
  File "/home/uroot/.local/lib/python3.10/site-packages/hio/base/doing.py", line 1026, in recur
    tock = dog.send(tyme)  # yielded tock == 0.0 means re-run asap
  File "/home/uroot/keripy/src/keri/app/delegating.py", line 138, in escrowDo
    self.processEscrows()
  File "/home/uroot/keripy/src/keri/app/delegating.py", line 143, in processEscrows
    self.processPartialWitnessEscrow()
  File "/home/uroot/keripy/src/keri/app/delegating.py", line 193, in processPartialWitnessEscrow
    self.hby.db.cdel.put(keys=(pre, seqner.qb64), val=serder.saider)
AttributeError: 'SerderKERI' object has no attribute 'saider'. Did you mean: 'said'?

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9b71bb) 81.42% compared to head (aa2d651) 81.42%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #157   +/-   ##
============================================
  Coverage        81.42%   81.42%           
============================================
  Files               46       46           
  Lines             4141     4141           
  Branches          1030     1030           
============================================
  Hits              3372     3372           
  Misses             737      737           
  Partials            32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psteniusubi
Copy link
Contributor Author

With the recent fixes in keripy this test is no longer causing Keria to crash.
Currently setting up delegate identifier with witness configuration just hangs and does complete, causing the test to time out.

@psteniusubi psteniusubi force-pushed the feat-integration-test-singlesig-dip branch from aaf6d88 to 926b76b Compare January 16, 2024 21:30
@pfeairheller
Copy link
Member

I copied this test locally and it runs with the current build so I'm merging this PR in.

@pfeairheller pfeairheller merged commit be1d8e6 into WebOfTrust:development Jan 16, 2024
6 checks passed
@psteniusubi psteniusubi deleted the feat-integration-test-singlesig-dip branch February 6, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants