Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run npm run lint -- --fix #154

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Dec 1, 2023

Running eslint --fix to fix all auto-fixable lint warnings and errors. I would not worry about conflicts too much because you can just run eslint --fix, either on this branch or any PR that might have conflicts.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Comparison is base (8be00bf) 81.21% compared to head (8279f85) 81.21%.

Files Patch % Lines
src/keri/app/controller.ts 48.97% 25 Missing ⚠️
src/keri/core/keeping.ts 53.84% 18 Missing ⚠️
src/keri/app/credentialing.ts 87.95% 10 Missing ⚠️
src/keri/core/prefixer.ts 38.46% 8 Missing ⚠️
src/keri/core/manager.ts 90.41% 7 Missing ⚠️
src/keri/core/matter.ts 87.50% 5 Missing ⚠️
src/keri/core/indexer.ts 89.74% 4 Missing ⚠️
src/keri/core/serder.ts 50.00% 4 Missing ⚠️
src/keri/core/httping.ts 81.25% 3 Missing ⚠️
src/keri/core/utils.ts 85.71% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##           development     #154   +/-   ##
============================================
  Coverage        81.21%   81.21%           
============================================
  Files               46       46           
  Lines             4136     4136           
  Branches          1023     1023           
============================================
  Hits              3359     3359           
  Misses             745      745           
  Partials            32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfeairheller
Copy link
Member

@lenkan This branch can't be merged until conflicts are resolved. Can you rebase and then we can get this in before other PRs pile up.

@lenkan
Copy link
Collaborator Author

lenkan commented Dec 1, 2023

@pfeairheller I have rebased this one now.

Copy link
Member

@pfeairheller pfeairheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope no one has lots of outstanding changes!

@pfeairheller pfeairheller merged commit c8c7c24 into WebOfTrust:development Dec 1, 2023
5 checks passed
@lenkan lenkan deleted the run-lint-fix branch December 4, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants