add multisig to integration tests #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #147 +/- ##
============================================
Coverage 81.01% 81.01%
============================================
Files 46 46
Lines 4187 4187
Branches 1028 1028
============================================
Hits 3392 3392
Misses 763 763
Partials 32 32 ☔ View full report in Codecov by Sentry. |
pfeairheller
approved these changes
Nov 28, 2023
|
@lenkan Why did only 2 integration tests run with this build? |
|
@pfeairheller This was branched from development. So the tests from #146 are not included. But I can rebase this branch now, then they will run. |
lenkan
force-pushed
the
multisig-integration-test
branch
from
dec7be6 to
a7b6b6e
Compare
|
This PR is superseeded by #150 if you decide to go with that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes just under 3 minutes on my machine. There are probably a lot more things that can be run concurrently to shorten it.