Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integration test for issuing chained credential #144

Merged

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Nov 22, 2023

As per discussion on Discord today. This is the reproduction script for issuing a chained credential to a holder using Signify.

When running this script, the holder never obtains the credential from its agent.

Resolves #155

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0727b6) 81.36% compared to head (600e08b) 81.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #144   +/-   ##
============================================
  Coverage        81.36%   81.36%           
============================================
  Files               46       46           
  Lines             4149     4149           
  Branches          1030     1030           
============================================
  Hits              3376     3376           
  Misses             741      741           
  Partials            32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan lenkan force-pushed the single-issuer-chained-credential branch from 9712b61 to aa081de Compare December 1, 2023 15:46
@pfeairheller
Copy link
Member

The code for this has been pushed to KERIA but the integration test now fails with a 404.

@lenkan lenkan force-pushed the single-issuer-chained-credential branch 4 times, most recently from f941c4c to 7265c06 Compare December 7, 2023 13:21
@lenkan lenkan marked this pull request as ready for review December 7, 2023 13:27
@lenkan lenkan force-pushed the single-issuer-chained-credential branch 3 times, most recently from b75f956 to b4d6b96 Compare December 7, 2023 13:31
@lenkan lenkan force-pushed the single-issuer-chained-credential branch from b4d6b96 to 600e08b Compare December 7, 2023 13:31
@lenkan lenkan changed the title add reproduction script for issuing chained credential add integration test for issuing chained credential Dec 7, 2023
@lenkan
Copy link
Collaborator Author

lenkan commented Dec 7, 2023

@pfeairheller I have converted this now to a test and to use the new grant and submitGrant methods.

@pfeairheller pfeairheller self-requested a review December 7, 2023 15:25
@pfeairheller pfeairheller merged commit 9698f50 into WebOfTrust:development Dec 7, 2023
5 checks passed
@lenkan lenkan deleted the single-issuer-chained-credential branch December 18, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPEX Grant with chained credentials
2 participants