Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cred chain #211

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Feat/cred chain #211

merged 3 commits into from
Oct 29, 2024

Conversation

HunnySajid
Copy link
Collaborator

@2byrds
Copy link
Collaborator

2byrds commented Oct 28, 2024

@HunnySajid can u add some screenshots?

@HunnySajid
Copy link
Collaborator Author

Credential View Changes
In the default or selection view, only those credentials that have issueName associated with them are displayed.

Screenshot 2024-10-29 at 12 05 50 AM

In default mode, each credential that have a chain displays an explore component, that expands and displays credential chain
Screenshot 2024-10-29 at 12 06 04 AM

Upon clicking a node in chain, it expands and shows its children if exist.

Upon clicking on folder icon on right side of a credential node, it takes user to that particular credential with its path displayed in breadcrumb.
Screenshot 2024-10-29 at 12 06 19 AM

Ideally, I wanted to make breadcrumb navigatable so that user can click on a breadcrumb and move to that credential but there was a challenge to maintain all user journey through this navigation.
For now, there is a back button in front of breadcrumb that takes user back to the original / default state of credential view.

Video Illustration

Screen.Recording.2024-10-29.at.12.14.33.AM.mov

@2byrds let me know your feedback

@HunnySajid
Copy link
Collaborator Author

HunnySajid commented Oct 28, 2024

@2byrds as in current example we are showing edges to root connection,
I was discussing with Aidar for a feature where we can show all of the credential chain from root to edges.

The idea is as follows:

  • Show an icon to explore along with the Credentials Heading
  • Once user clicks on it, it opens a separate extension page in browser eg extension_id/credential_chain
  • That page displays a connection tree from root credential to different edges like a map
    We might be able to discuss and refine this.

@2byrds
Copy link
Collaborator

2byrds commented Oct 28, 2024

Great stuff @HunnySajid thank you for posting. I'll give more feedback once I've used it.

@Jayharwani
Copy link

The Idea seems nice!
@HunnySajid just a small sugesstion, you can also add a drop down menu icon near to the explore and credential chain so end users can know something is there and click on it otherwise first time users won't be able to there is a chain.

@HunnySajid
Copy link
Collaborator Author

The Idea seems nice! @HunnySajid just a small sugesstion, you can also add a drop down menu icon near to the explore and credential chain so end users can know something is there and click on it otherwise first time users won't be able to there is a chain.

Thanks @Jayharwani for the suggestion, I added a ">" in collapsed state of a node

Screen.Recording.2024-10-29.at.6.25.43.PM.mov

@HunnySajid HunnySajid merged commit 2799a16 into WebOfTrust:main Oct 29, 2024
@Jayharwani
Copy link

The Idea seems nice! @HunnySajid just a small sugesstion, you can also add a drop down menu icon near to the explore and credential chain so end users can know something is there and click on it otherwise first time users won't be able to there is a chain.

Thanks @Jayharwani for the suggestion, I added a ">" in collapsed state of a node

Screen.Recording.2024-10-29.at.6.25.43.PM.mov

Perfect!

@HunnySajid HunnySajid deleted the feat/cred-chain branch December 4, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants