Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all KASLcred 0.0.8 code #2

Merged
merged 2 commits into from
May 11, 2023
Merged

Add all KASLcred 0.0.8 code #2

merged 2 commits into from
May 11, 2023

Conversation

kentbull
Copy link
Contributor

This is all of the code I wrote for the KASLCred utility

@kentbull kentbull mentioned this pull request Apr 4, 2023
Closed
dhh1128
dhh1128 requested changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@dhh1128 dhh1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks quite useful to me. However, I suggest we put it in a subdir called "tools" -- so, "tools/kasl", for example, rather than treating the root of the repo as the root of kasl.

@kentbull
Copy link
Contributor Author

kentbull commented May 6, 2023

Yes, @dhh1128 I agree, I will put it in the "tools" subdirectory.

@m00sey
Copy link
Member

m00sey commented May 10, 2023

tools/KASLcred would be ideal, in case we have others

@m00sey m00sey self-requested a review May 10, 2023 14:26
@m00sey
Copy link
Member

m00sey commented May 10, 2023

Closes #1

m00sey
m00sey requested changes May 10, 2023
View reviewed changes
Copy link
Member

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tools/kaslcred

@kentbull
Copy link
Contributor Author

Just moved it to /toos/kaslcred

@m00sey m00sey merged commit d107e81 into WebOfTrust:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhh1128 dhh1128 dhh1128 requested changes

@m00sey m00sey m00sey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kentbull @m00sey @dhh1128