Feat/ci checks #26
Merged
Feat/ci checks #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think husky should be in place but can be skipped if neccessary. Just make |
|
@lenkan can you please review/merge this ? |
lenkan
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Nice work @HunnySajid . Good to have some sanity checks here.
I have added some comments of what I think should change and some questions.
Co-authored-by: Daniel Lenksjö <[email protected]>
HunnySajid
commented
Sep 12, 2024
HunnySajid
commented
Sep 12, 2024
There was a problem hiding this comment.
@lenkan Thanks for your feedback.
I have updated workflow to have single job, prettier to format all (except example folder), and build confit to emit code.
lenkan
reviewed
Sep 13, 2024
Thanks for the keen eye, i have updated the command |
lenkan
approved these changes
Sep 13, 2024
|
@2byrds can you please merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #23
Addes Precommit (Husky) and Github workflow for:
Prettier format check
Eslint linting
Typescript typecheck
Vitest test run