-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds rp to exn to work with >1.2.0-dev4 #905
Conversation
Signed-off-by: Kevin Griffin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "newer KERI"?
@@ -304,7 +304,7 @@ class Serder: | |||
Ilks.bar: Fieldage(saids={Saids.d: DigDex.Blake3_256}, | |||
alls=dict(v='', t='',d='', i='', dt='', r='',a=[])), | |||
Ilks.exn: Fieldage(saids={Saids.d: DigDex.Blake3_256}, | |||
alls=dict(v='', t='', d='', i="", p="", dt='', r='', q={}, | |||
alls=dict(v='', t='', d='', i="", rp="", p="", dt='', r='', q={}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the RP field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is against 1.1 - renamed to be clear.
Rp field was added 1.2.0-dev4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is against 1.1 - renamed to be clear.
Rp field was added 1.2.0-dev4
Sure, but what is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top level recipient field. This was discussed some time ago, hence its addition to 1.2.+
It was added to save unpacking the a.r
field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top level recipient field. This was discussed some time ago, hence its addition to 1.2.+ It was added to save unpacking the
a.r
field.
Do you remember when? It hasn't been added to the specs yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specs show Ver_2_0 but it looks like it’s ri
in there, these are against Ver_1_0 and Ver_1_1
The fix should be that an
|
No description provided.