Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed --alias from verify command. #867

Merged

Conversation

daidoji
Copy link
Contributor

@daidoji daidoji commented Sep 23, 2024

Prefixes are 1-1 with aliases which are already required for this command and thus redundant. Removed for ease of use.

@pfeairheller
Copy link
Member

The --prefix option is meant to specify the signer of the data, not the one verifying it. The tests in demo-script.sh are misleading because they use the same AID for signing and verifying.

If anything, the --alias argument can be removed because you don't need a Hab context to verify someone else's signature, you just need the Habery database so you load their key state in the Kevers.

@daidoji
Copy link
Contributor Author

daidoji commented Sep 23, 2024

The --prefix option is meant to specify the signer of the data, not the one verifying it. The tests in demo-script.sh are misleading because they use the same AID for signing and verifying.

If anything, the --alias argument can be removed because you don't need a Hab context to verify someone else's signature, you just need the Habery database so you load their key state in the Kevers.

@pfeairheller so how would I restructure this not to have to use an alias to verify? Nothing in the verify command looks like its making a remote call to a prefix KEL in the wild so aren't aliases and prefixes 1-1 in the current implementation?

@pfeairheller
Copy link
Member

The appropriate change here is to remove the --alias argument because a local Hab is not needed to verifiy a signature. The --prefix parameter is to allow the verification of signatures from other folks AIDs. If we rely on --alias and a Hab, we can only verify our own signatures.

To remove --alias you need to change

with existing.existingHab(name=name, alias=alias, base=base, bran=bran) as (_, hab):

to:

with existing.existingHby(name=name, base=base, bran=bran) as hby:

And then change hab.kevers to hby.kevers

@daidoji daidoji changed the title Removed --prefix from verify command. Removed --alias from verify command. Nov 5, 2024
@pfeairheller pfeairheller merged commit 676d519 into WebOfTrust:main Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants