-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notes datetime ISO 8601 format #827
Conversation
Any interest in fixing the other usages of datetime vs helping.nowISO() @rodolfomiranda 😬 |
I could only find |
Thanks, appreciate you taking the extra time. |
Can we please explain in the description of the PR why this change is being made? The helping functions are used in many other places in KERIpy, specifically for time in KERI events and credentials. Why are you proposing we change them for only this small subset of date usages? If the date functions are wrong, why not fix them? |
date functions are correct, but were not applied correctly in a couple of lines in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I definitely reviewed this PR too early in the morning... I read it backwards!!
Looks good to me!
Should be using helping.nowIso8601() or helping.toIso8601 everywhere there is a datetime string (non CESR encoded). Or Dater instance if want CESR encoded datetime |
Notes that are not initiated with a
dt
parameter, are being created with a defaultdt
that don't follows the ISO 8601 format. The class use the functiondatetime.datetime.now().isoformat()
to create the string timestamp that result in a value without timezone or offset such as2023-10-05T14:48:23.123456
.Instead,
keripy
normal usehelping.nowIso8601()
to create the timestamp that result in values like2021-06-27T21:26:21.233257+00:00