Writing logs into file is configurable from cli argument #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeairheller
approved these changes
Apr 4, 2024
kentbull
pushed a commit
to kentbull/keripy
that referenced
this pull request
Jul 8, 2024
kentbull
pushed a commit
to kentbull/keripy
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As keripy is mostly running inside a docker container, so writing logs into the console makes sense, and we can utilize the docker daemons log rotation feature. Recently we saw keripy also writing logs into a temporary file (in
/tmpdirectory) inside the container. And it doesn't rotate the log. So the storage is getting full. And there is no way to modify this behavior without changing the code. I hope this CLI argument will make life easier.