Non deterministic prefixes in witnesses #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed hardcoded salts as default behavior of openHby and openHab. Also fixed a bug that hadn't been caught yet wherein whatever was passed to openHby was always used and a default salt was never created. Adjusted to match the intention of the code and no tests seemed to break from it so it must have been getting caught further down the stack.
pfeairheller
requested review from
pfeairheller and
SmithSamuelM
and removed request for
pfeairheller
SmithSamuelM
approved these changes
Mar 7, 2024
pfeairheller
added a commit
to pfeairheller/keria
that referenced
this pull request
Mar 9, 2024
…inistic salts that broke a bunch of tests here. Signed-off-by: pfeairheller <[email protected]>
pfeairheller
added a commit
to WebOfTrust/keria
that referenced
this pull request
Mar 9, 2024
…inistic salts that broke a bunch of tests here. (#210) Signed-off-by: pfeairheller <[email protected]>
kentbull
pushed a commit
to kentbull/keripy
that referenced
this pull request
Jul 8, 2024
* Added ctags * Fix to remove hardcoded salts as default behavior. Removed hardcoded salts as default behavior of openHby and openHab. Also fixed a bug that hadn't been caught yet wherein whatever was passed to openHby was always used and a default salt was never created. Adjusted to match the intention of the code and no tests seemed to break from it so it must have been getting caught further down the stack. * Removed erroneous print statement * Removed a deleted space that had entered the diff
kentbull
pushed a commit
to kentbull/keripy
that referenced
this pull request
Sep 3, 2024
* Added ctags * Fix to remove hardcoded salts as default behavior. Removed hardcoded salts as default behavior of openHby and openHab. Also fixed a bug that hadn't been caught yet wherein whatever was passed to openHby was always used and a default salt was never created. Adjusted to match the intention of the code and no tests seemed to break from it so it must have been getting caught further down the stack. * Removed erroneous print statement * Removed a deleted space that had entered the diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed hardcoded salts as default behavior of openHby and openHab.
Also fixed a bug that hadn't been caught yet wherein whatever was passed to openHby was always used and a default salt was never created. Adjusted to match the intention of the code and no tests seemed to break from it so it must have been getting caught further down the stack.