Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image python:3.10-alpine; Fix docker COPY build failure #671

Merged

Conversation

clackwork
Copy link
Contributor

@clackwork clackwork commented Feb 6, 2024

By using a less specific base image we can be right more often while doing less maintenance grunt-work on our Docker image. By using 3.10 instead of 3.10.13, our code will still be correct when 3.10.14 is released. Similarly, by using "alpine" instead of "alpine 3.18", we are still presently using the latest stable version of Alpine 3 (3.18) while being upgraded automatically to the latest stable version when it becomes available.

Reference:

Also, fix docker build bug with COPY:

Step 9/17 : COPY requirements.txt setup.py .
When using COPY with more than one source file, the destination must be a directory and end with a /

@clackwork clackwork marked this pull request as ready for review February 6, 2024 23:24
@m00sey m00sey self-assigned this Feb 8, 2024
@pfeairheller
Copy link
Member

Not sure why this was tagged pre-release, it is based off of development. If you want it in pre-release, it needs to be changed to the release branch.

@m00sey
Copy link
Member

m00sey commented Feb 9, 2024

I thought I said during the call it was tagged for discussion.

@pfeairheller pfeairheller merged commit e9c09f9 into WebOfTrust:development Feb 12, 2024
6 checks passed
pfeairheller added a commit that referenced this pull request Feb 12, 2024
pfeairheller added a commit that referenced this pull request Feb 13, 2024
@pfeairheller
Copy link
Member

Apologies, I merged this into development instead of the release branch so I had to revert it. I've included these changes in my current PR that I'll merge this morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants