Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for https endpoints in witnesses, controllers and agents #91

Closed

Conversation

rodolfomiranda
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #91 (2273123) into development (23027b8) will decrease coverage by 0.02%.
The diff coverage is 84.61%.

@@               Coverage Diff               @@
##           development      #91      +/-   ##
===============================================
- Coverage        88.20%   88.18%   -0.02%     
===============================================
  Files               30       30              
  Lines             4789     4799      +10     
===============================================
+ Hits              4224     4232       +8     
- Misses             565      567       +2     
Files Changed Coverage Δ
src/keria/app/aiding.py 77.67% <71.42%> (-0.07%) ⬇️
src/keria/app/agenting.py 81.43% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pfeairheller
Copy link
Member

See my comment to WebOfTrust/keripy#555. Same applies here

@rodolfomiranda
Copy link
Collaborator Author

This PR is in line with the merged PR on keripy WebOfTrust/keripy#555

@psteniusubi
Copy link
Contributor

Hi @rodolfomiranda
I just tried this fix with some smallish issues.
My https witness endpoints have no port, for example https://witness-5642.io.ubidemo1.com
This causes keri to generate invalid oobi urls with :None as port, like this https://witness-5642.io.ubidemo1.com:None

@rodolfomiranda
Copy link
Collaborator Author

YEs, you are correct. We faced the same issues. I'll add that change as well.

@psteniusubi
Copy link
Contributor

It looks like this issue exists in many places of keripy too.
I think it would be simpler to generate urls with urljoin, using the configured url as base.
Thanks!

@rodolfomiranda
Copy link
Collaborator Author

I'm replacing this PR with #103

@iFergal iFergal deleted the https-wits branch November 16, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants