Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix limit and skip in credential query #82

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

rodolfomiranda
Copy link
Collaborator

No description provided.

Rodolfo Miranda added 2 commits August 2, 2023 22:33
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #82 (9423f53) into main (afa1c9b) will increase coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   86.92%   87.01%   +0.08%     
==========================================
  Files          29       29              
  Lines        4491     4513      +22     
==========================================
+ Hits         3904     3927      +23     
+ Misses        587      586       -1     
Files Changed Coverage Δ
src/keria/app/credentialing.py 78.26% <100.00%> (+0.46%) ⬆️
tests/app/test_credentialing.py 99.70% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rodolfomiranda rodolfomiranda marked this pull request as draft August 3, 2023 01:50
@rodolfomiranda
Copy link
Collaborator Author

converted to draft, I need to add more tests

@rodolfomiranda rodolfomiranda marked this pull request as ready for review August 3, 2023 12:51
Copy link
Member

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m00sey m00sey merged commit dd342a7 into WebOfTrust:main Aug 3, 2023
@iFergal iFergal deleted the fix_vc_query branch November 16, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants