-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interceptor #67
Closed
Closed
Interceptor #67
Changes from 8 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
dbb56e9
add interceptor
AlexAndrei98 2a68ce4
fix typos
AlexAndrei98 840487f
fix init error
AlexAndrei98 b57fe97
test interceptor
AlexAndrei98 e212ef5
refactor to use hio
AlexAndrei98 47e9a07
remove requests dependecy
AlexAndrei98 2b6a66f
Update test_agenting.py
AlexAndrei98 47b829f
clean up metrics
AlexAndrei98 2d7a1bf
calling interceptor
AlexAndrei98 2f49ed4
Update to interceptor to work correctly as a DoDoer.
pfeairheller 2a270b4
try getting deck into endpoints
AlexAndrei98 2d27449
refactor to intercepts for Deck
AlexAndrei98 fa34931
Merge branch 'main' into interceptor
AlexAndrei98 5769cca
refactor to handle non configured case
AlexAndrei98 6b7d685
fix startup issue
AlexAndrei98 b70889a
Update agenting.py
AlexAndrei98 01b0845
keep doer in list
AlexAndrei98 443e139
fix tests
AlexAndrei98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the list of doers, you have to include
self.interceptor
in this list to get the recur method to be called as a background process.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I not put it when I Initialize the agency
super(Agency, self).__init__(doers=[self.interceptor], always=True)
on Line 132 instead of having a logger per agent, I was thinking that since we have a queue per agency instead of agentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pfeairheller I also tried passing
self.agency.interceptor
but it still not running. Does Interceptor need to be Just a Doer Since Agent is a DoDoer?