-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use SAID for long running operation oid instead of identifier prefix #289
feat: use SAID for long running operation oid instead of identifier prefix #289
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 93.06% 93.68% +0.62%
==========================================
Files 36 36
Lines 7121 7859 +738
==========================================
+ Hits 6627 7363 +736
- Misses 494 496 +2 ☔ View full report in Codecov by Sentry. |
will improve coverage later/tomorrow but otherwise ready for review impl wise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… make sense given the impl in longrunning.py)
@rodolfomiranda @2byrds The oid I had for I've reverted that section because longrunning.py simply checks if the submits have finished completing for all things related to that agent, rather than specifically for the identifier. So that probably needs some more attention itself in another PR |
To address #285.
I initially required this for exn messages but decided to apply it everywhere because otherwise I think we may run into other edge case issues.
Signify-TS integration tests all pass with minor adjustment.