-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get credential by said 404 response #282
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 93.06% 93.70% +0.64%
==========================================
Files 36 36
Lines 7121 7863 +742
==========================================
+ Hits 6627 7368 +741
- Misses 494 495 +1 ☔ View full report in Codecov by Sentry. |
Actually, there is |
WebOfTrust/keripy#841 merged, will update this when there's a release with it and I'm free |
cc @2byrds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rgy.reger.cloneCred
orcloneCreds
will cause a 500 error if the credential does not exist:I fixed this in keripy to throw a missing entry error: WebOfTrust/keripy#841
So just catching that and returning 404.