updates for escrow fix, align with kerupy 1.1.17 and #235 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Griffin <[email protected]>
Signed-off-by: Kevin Griffin <[email protected]>
2byrds
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Please remove the 'Submitter' functionality/endpoint you have added. It is a partial addition that will conflict with the work i'm doing here https://github.com/2byrds/keria/tree/feat/submit_id
Given the divergent nature of keria 0.1.x using keripy 1.1.x and keria 0.2.x using keripy 1.2.x it might be best to leave as is and when we review the prs we can make the best choice of does one start at 0.1 and move forward to 0.2 or vice verse. |
|
Ned to update keripy ref to pull in hio fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.