Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PR attempts to catch up with KERIpy delegation logic #246

Merged
merged 2 commits into from
May 29, 2024

Conversation

pfeairheller
Copy link
Member

@pfeairheller pfeairheller commented May 21, 2024

This PR includes:

  • fix to delegation logic to submit to witnesses first, then ask for delegation approval
  • Update to newest development release of KERIpy and added call to new Kevery.processEscrowDelegables() during escrow processing.

This PR closes #245

…pproval. Also switched the agent parser to local=True
…Kevery.processEscrowDelegables() during escrow processing.

Signed-off-by: pfeairheller <[email protected]>
@2byrds
Copy link
Collaborator

2byrds commented May 21, 2024

Great! I'll test it in about an hour

@2byrds
Copy link
Collaborator

2byrds commented May 22, 2024

@pfeairheller I got an exception during the delegableEscrow processing and KERIA crashed. I commented on the KERIpy PR to point out what caused the crash. I'll look into why i'm getting the exception with more testing tomorrow

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll be doing a follow-on PR to approve the delegation

@2byrds 2byrds merged commit 6b33043 into main May 29, 2024
3 checks passed
@pfeairheller pfeairheller deleted the feat-fix-delegation branch June 13, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add call to kvy.processDelegablesEscrow to Agent's Escrow Doer
2 participants