Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 400 when Serder validation fails #234

Merged
merged 5 commits into from
May 6, 2024

Conversation

rodolfomiranda
Copy link
Collaborator

This PR is related to #201

@pfeairheller
Copy link
Member

The TraitCodex and MacOS problems are now fixed on main. Please rebase to pick them up.

@rodolfomiranda
Copy link
Collaborator Author

The TraitCodex and MacOS problems are now fixed on main. Please rebase to pick them up.

done

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.78%. Comparing base (5f06007) to head (90c5432).
Report is 10 commits behind head on main.

❗ Current head 90c5432 differs from pull request most recent head 36fa77f. Consider uploading reports for the commit 36fa77f to get more accurate results

Files Patch % Lines
src/keria/app/credentialing.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   93.08%   92.78%   -0.30%     
==========================================
  Files          38       37       -1     
  Lines        7002     6990      -12     
==========================================
- Hits         6518     6486      -32     
- Misses        484      504      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution.

@2byrds 2byrds merged commit 44cc2d8 into WebOfTrust:main May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants