Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add index for registry field #188

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Feb 8, 2024

First of all need to know if this is a good idea. It would be useful for me. Let me know what you think.

Closes #187

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-0.1.0-rc.1@e8445b4). Click here to learn what that means.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             release-0.1.0-rc.1     #188   +/-   ##
=====================================================
  Coverage                      ?   92.72%           
=====================================================
  Files                         ?       38           
  Lines                         ?     6597           
  Branches                      ?        0           
=====================================================
  Hits                          ?     6117           
  Misses                        ?      480           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pfeairheller
Copy link
Member

Please rebase this to a PR against the release branch

@lenkan lenkan force-pushed the feat-credential-query-registry branch from 62c30e9 to 80620d7 Compare February 10, 2024 08:28
@lenkan lenkan changed the base branch from development to release-0.1.0-rc.1 February 10, 2024 08:29
@lenkan
Copy link
Collaborator Author

lenkan commented Feb 10, 2024

Right, thanks. Was not sure about the workflow. Rebased and changed base branch now.

@pfeairheller pfeairheller merged commit fafe5b6 into WebOfTrust:release-0.1.0-rc.1 Feb 13, 2024
5 checks passed
@lenkan lenkan deleted the feat-credential-query-registry branch September 2, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for filtering credentials by registry
3 participants